ioos / ioos/xarray-subset-grid
Extraneous grid types?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 11
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 4
Description
Currently in the grids, we have:
fvcom_grid.py
regular_grid.py
regular_grid_2d.py
selfe_grid.py
sgrid.py
ugrid.py
However, I can't see what regular_grid_2d.py does -- why make the distiction beetween 2D and 3D here? and if so, they should share more code.
and fvcom and selfe are both unstructured grids, so should be handled by ugrid, yes? (at least fvcom is now...)
@mpiannucci : do you remember what this is about? experiments when getting started? CAn we simply remove those?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read fvcom_grid.py, regular_grid.py, regular_grid_2d.py, selfe_grid.py, sgrid.py, and ugrid.py to determine how the grid implementations differ and whether their responsibilities overlap. Check the existing grid usage before deciding whether to share code, move unstructured-grid behavior into ugrid.py, or remove files; done means the resulting structure is justified and existing users remain supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100