ionide / ionide/FsAutoComplete

Better handling of ClientCapabilities for different editors

Open
#1,032 3 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
F#
Stars
486
Forks
169
Avg merge
2d 8h
Merged PRs (30d)
5

Description

After troubleshooting some other LSP Clients (namely emacs and helix) on the Discord server, FSAC will eventually crash. It seems these clients have trouble with the `fsharp/` specific notifications that come from FSAC. [Fsharp language server put in some fixes regarding this type of behavior too.](https://github.com/fsprojects/fsharp-language-server/commit/0b7f6a761c7636bd1f1add57b6454a37d1b205cf) I'm unsure what exactly the best path of action is here.

1. Put a flag in so we know we're talking to Ionide, otherwise just no-op the `fsharp/` calls. (quick)
2. Better handling at the LSP Client level at parsing bad information from standard in (unsure how much work is related here)
3. Make other clients not send stuff to standard in when they receive notifications they can't handle (given 2 separate editors seem to have this behavior, I'm unsure if they're at fault here).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.