ionide / ionide/FsAst

New versions of Fantomas require trivia to have some value

Open
#44 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
F#
Stars
48
Forks
15
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
After updating Myriad (and consequently Fantomas), all the generated code misses keywords, turns out new Fantomas versions require a non-None value for trivia, but most of the helpers generate it with None, causing all the generated AST to produce nonsense code.

**Describe the solution you'd like**
Can all the default record and helper methods generate trivia with `Some Range.Zero` by default?

**Describe alternatives you've considered**
Dropping FsAst and re-writing all the code to create unions directly
Cloning the repository and making the changes myself and reference locally

**Additional context**
Please see here: https://github.com/MoiraeSoftware/myriad/issues/154
Started playing with it here: https://github.com/ionide/FsAst/commit/a6649ec1a49f004e1769cb75df3928fc822c96c8

Thank you.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.