ionic-team / ionic-team/rollup-plugin-node-polyfills

global undefined in process polyfill

Open
#42 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
142
Forks
65
PR merge metrics
No merged PRs in 30d

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `rollup-plugin-node-polyfills@0.2.1` for the project I'm working on.

'process' polyfill fails for me at runtime trying to reference 'global'. There is a separate polyfill for 'global', so I just referenced that in the process polyfill and it resolved my issue.

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/rollup-plugin-node-polyfills/polyfills/process-es6.js b/node_modules/rollup-plugin-node-polyfills/polyfills/process-es6.js
index b7205a5..47de4a7 100644
--- a/node_modules/rollup-plugin-node-polyfills/polyfills/process-es6.js
+++ b/node_modules/rollup-plugin-node-polyfills/polyfills/process-es6.js
@@ -1,6 +1,9 @@
// shim for using process in browser
// based off https://github.com/defunctzombie/node-process/blob/master/browser.js

+import global from "./global";
+
+
function defaultSetTimout() {
throw new Error('setTimeout has not been defined');
}
```

This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.