ionic-team / ionic-team/ioniconf-app
Usage of effects looks strange
Open
- Dominant language
- TypeScript
- Stars
- 15
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
Why using an effect for this?
https://github.com/ionic-team/ioniconf-app/blob/main/src/app/store/speakers/speakers.effects.ts
this.eventFacade.event$ emits the data which is available in the Store already (synchronously).
Store selectors can easily do what is happening now in the reducer:
https://github.com/ionic-team/ioniconf-app/blob/main/src/app/store/speakers/speakers.reducer.ts#L17-L28
The effect looks like there was a real API call in an earlier version.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.