ionic-team / ionic-team/ioniconf-app
Effects should use catchError, otherwise the effect could stop working in case of API error
Open
- Dominant language
- TypeScript
- Stars
- 15
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
At the moment the catchErrors are commented out.
In fact catchError is strongly advised to use:
Read more here:
https://ngrx.io/guide/effects#handling-errors
NgRx has a safety net for resubscribing automatically. But it does so only 10 times for an effect.
Read more here:
https://ngrx.io/guide/effects/lifecycle#resubscribe-on-error
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.