ionic-team / ionic-team/ionic-framework

bug: reatct, route jump using replace will not destroy the page dom

Open
#25,640 7 comments 0 reactions 0 assignees View on GitHub
package: react type: bug
Dominant language
TypeScript
Stars
52.7k
Forks
13.3k
Avg merge
1d 15h
Merged PRs (30d)
51

Description

### Prerequisites

- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

- [ ] v4.x
- [X] v5.x
- [x] v6.x
- [ ] Nightly

### Current Behavior

When I use replace in the jump path, it causes the page to stay in the dom forever. Will not be destroyed, enter the page again, the useEffect method will not be executed。

for example :
/test/test1 (replace)-> /test/test2/:location (replace) -> /test/test3/:location (push) -> /test/test4/:location (navigate('/test/test1', 'back', 'pop')) -> /test/test1 (replace)-> /test/test2/:location (replace) -> /test/test3/:location

Finally, when you enter the test3 page, you cannot get the latest parameters of history params, and the useEffect method will not be executed.

### Expected Behavior

Hope to get the latest parameters and executed useEffect function,It now appears that the page remains in the dom and is not destroyed.

### Steps to Reproduce

/test/test1 (replace)-> /test/test2/:location (replace) -> /test/test3/:location (push) -> /test/test4/:location (navigate('/test/test1', 'back', 'pop')) -> /test/test1 (replace)-> /test/test2/:location (replace) -> /test/test3/:location

Reproducible using the project I provided

### Code Reproduction URL

https://github.com/yunfeng-weee/ionic-router-question

### Ionic Info

Ionic:

Ionic CLI : 6.20.1 (D:\nvm\v14.18.1\node_modules\@ionic\cli)
Ionic Framework : @ionic/react 5.9.4

Capacitor:

Capacitor CLI : 3.6.0
@capacitor/android : 3.6.0
@capacitor/core : 3.6.0
@capacitor/ios : 3.6.0

Utility:

cordova-res : not installed globally
native-run : 1.6.0

System:

NodeJS : v14.18.1 (D:\nodejs\node.exe)
npm : 6.14.15
OS : Windows 10

### Additional Information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.