ionic-team / ionic-team/ionic-framework

bug: react, router.go does not show correct view when n < -1

Open
#23,775 7 comments 11 reactions 0 assignees View on GitHub
package: react type: bug
Dominant language
TypeScript
Stars
52.7k
Forks
13.3k
Avg merge
1d 15h
Merged PRs (30d)
51

Description

### Prequisites

- [X] I have read the [Contributing Guidelines](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#creating-an-issue).
- [X] I agree to follow the [Code of Conduct](https://ionicframework.com/code-of-conduct).
- [X] I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success.

### Ionic Framework Version

- [ ] v4.x
- [X] v5.x
- [ ] v6.x

### Current Behavior

Navigating using `router.go(n)` with an `n` value less than `-1`, Ionic React does not show the correct view because it always assumes a delta of `1` or `-1`.

### Expected Behavior

I would expect Ionic React to show the correct view regardless of the delta value.

### Steps to Reproduce

1. Start with one page and push 2 IonPages to navigation stack via navigation.push()
2. Let the 3rd page navigate back ("history stack pop") to the first page via navigation.go(-2)
3. Observe that react's router does produce the proper URL (path) of the first page. But also observe that the the previous route (page) in the history stack is rendered, not the very first page which belongs to that path.

### Code Reproduction URL

https://github.com/larsblumberg/ionic-back-navigation-broken

### Ionic Info

_No response_

### Additional Information

This is a continuation of https://github.com/ionic-team/ionic-framework/issues/22563.

At the time of writing, there does not seem to be a straightforward way to implement this. The fix for this in Ionic Vue relied on Vue Router exposing a delta value as well as a custom state object in `window.history.state` that let us track which view to show. React Router does not expose this kind of information according to https://github.com/remix-run/history/issues/36#issuecomment-233652964 and https://github.com/remix-run/history/issues/334#issuecomment-244250026.

One option is we could build this position tracking into Ionic React ourselves, but I am a bit hesitant to start altering `window.history.state` especially when React Router already manages the state for us.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.