ionic-team / ionic-team/ionic-docs

content: document alternative to dismissOnPageChange (ionNavWillChange, ionNavDidChange)

Open
#846 0 comments 0 reactions 0 assignees View on GitHub
content
Dominant language
MDX
Stars
621
Forks
3.2k
Avg merge
1d 2h
Merged PRs (30d)
86

Description

**URL**
https://github.com/ionic-team/ionic-framework/blob/main/BREAKING_ARCHIVE/v4.md#overlays

**What is missing or inaccurate about the content on this page?**
The doc says that as a workaround for the removed dismissOnPageChange, `there are global events (ionNavWillChange, ionNavDidChange) that you can listen to in order to detect when navigation occurs.`

I can't find any documentation anywhere on how to actually use ionNavDidChange, so this is not a great proposed alternative.

I managed to get it working using this code in app.component.ts to subscribe to Angular router events:

```
router.events.subscribe(event => {
if (event instanceof NavigationEnd) {
// Do something
}
});
```
Perhaps this should be documented as an alternative to dismissOnPageChange.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.