ionic-team / ionic-team/ionic-docs

content: using "aria-labelledby", as suggested by the Accessibility Guidelines, never worked with modals

Open
#3,809 0 comments 0 reactions 0 assignees View on GitHub
content
Dominant language
MDX
Stars
621
Forks
3.2k
Avg merge
1d 2h
Merged PRs (30d)
86

Description

### URL

https://ionic.io/docs/accessibility/ion-modal

### Issue Description

In the Accessibility Guidelines for modals, it says:

> In the above example the logical choice for an accessible name would be the `ion-title` of "Welcome". We can associate the modal with this by setting the `aria-labelled` attribute and giving the `ion-title` an id:

Leaving aside that it should be `aria-labelledby`, this has never worked as the only two attributes that are pushed down to the actual `div` that also gets assigned the `role` attribute of "dialog" are `role` and `aria-label`, as seen here in [the code for modal](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/modal/modal.tsx#L367).

So either the code needs a fix to support `aria-labelledby`, or the docs need to be adjusted.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.