ionic-team / ionic-team/ionic-cli

Tabs template should set <tabName>Root with page class reference instead of page name string

Open
#3,320 0 comments 0 reactions 0 assignees View on GitHub
triage
Dominant language
TypeScript
Stars
2k
Forks
682
PR merge metrics
No merged PRs in 30d

Description

Now the template is like below.

```typescript
export class TabsPage {

tab1Root = 'Tab1Page' // Look here
tab2Root = 'Tab2Page'
tab3Root = 'Tab3Page'

constructor(public navCtrl: NavController) { }

}
```

This causes url problem on desktop browser. When the first tab is selected, the url will be changed to something like `http://localhost:8101/#/tab1`. I spend hours to find out the solution: change `'Tab1Page'` to `Tab1Page` and import the class.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.