ionic-team / ionic-team/capacitor-google-maps

Refactor options and extend a method to update the map options

Open
#25 0 comments 2 reactions 0 assignees View on GitHub
triage
Dominant language
TypeScript
Stars
32
Forks
47
PR merge metrics
No merged PRs in 30d

Description

## Feature Request

### Plugin
@capacitor/google-maps

### Description
This feature request has 2 topics

#### Refactor options
- As styles also exists in `google.maps.MapOptions` it could be removed from `GoogleMapsConfig`. I think you added it here, to show it in the documentation, but I would rather write a comment above the class, which properties from `google.maps.MapOptions` are supported
- To prevent overhead, the `MapType` class could be deleted, because its documented in `google.maps.MapOptions`
- The following methods could be removed and implemented within the options object (this would require to have a `update` method, see below):
- getMapType
- setMapType
- enableIndoorMaps
- enableTrafficLayer
- enableAccessibilityElements
- enableCurrentLocation
- setPadding
- There should be some additional options in `GoogleMapsConfig` like:
- isCompassEnabled
- isRotateGesturesEnabled
- isTiltGesturesEnabled
- isToolbarEnabled
- isZoomGesturesEnabled
- Some more properties of `google.maps.MapOptions` should be handled by the native code like:
- gestureHandling
- restriction

#### Add an update method for map options
The above defined changes should also be appliable by an update method, to change them after the map instantiation.

### Platform(s)
Android
iOS
Web

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.