ioet / ioet/time-tracker-backend

Remove static methods from TimeEntriesDao

Open
#227 0 comments 0 reactions 1 assignee Claimed by @gqroot View on GitHub
code-smell mvp tech-debt
Dominant language
Python
Stars
5
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The class TimeEntriesDao has the following static method:
```
@staticmethod
def current_user_id():
return current_user_id()
```

As you can see, it returns an existing function part of the security.py file. We can use directly that function instead of returning the same function. Please refactor this, we should aim for having 0 static methods. We should use either a POO approach or functions directly. But it does not make any sense to have static methods.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.