iodide-project / iodide-project/iodide

Should update userDefinedVarNames in state even when eval errors

Open
#2,345 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.5k
Forks
145
PR merge metrics
No merged PRs in 30d

Description

currently, userDefinedVarNames only updates after an eval that runs to completion without error, but variables can be successfully defined even if the chunk errors overall. see this NB, watch the workspace pane:
https://alpha.iodide.io/notebooks/3404/

i think this is a quick fix in eval-queue-saga.js

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.