iodide-project / iodide-project/iodide

`ctrl + enter` will open modal if modal NoteBookMenuItem is in selected state.

Open
#2,155 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.5k
Forks
145
PR merge metrics
No merged PRs in 30d

Description

The `ctrl + enter` shortcut seems to open a NoteBookMenuItem in the header if the item is in a focused state, this does not occur with `shift + enter`. Issue first discovered in #2100.

### What I Did

The following steps were taken to reproduce this issue:
1. Navigate to help modal NotebookMenuItem located in right side of the header
2. Select help menu item
3. Close help menu item
4. Press `ctrl + enter`

### What I Expected

I expected the notebook to be evaluated without the modal opening.

![expected](https://user-images.githubusercontent.com/8524802/63066281-29735a00-bebe-11e9-9e85-fca831789f55.PNG)

### What Happened

The modal opened and sometimes notebook is evaluated.

![actual](https://user-images.githubusercontent.com/8524802/63066287-2d9f7780-bebe-11e9-8df6-ad5f87dff71a.PNG)

### (if applicable) notebook that reproduces bug
[https://local-iodide.herokuapp.com/](https://local-iodide.herokuapp.com/)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.