invertase / invertase/flutterfire_cli

[bug]: run dart format on `firebase_options.dart`

Open
#290 1 comment 3 reactions 0 assignees View on GitHub
enhancement keep open
Dominant language
Dart
Stars
193
Forks
74
PR merge metrics
No merged PRs in 30d

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues.

### CLI Version

1.0.0

### Firebase Tools version

13.7.2

### Flutter Doctor Output

```
[✓] Flutter (Channel stable, 3.19.6, on macOS 14.4.1 23E224 darwin-arm64,
locale en-NO)
• Flutter version 3.19.6 on channel stable at /Users/erlend/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 54e66469a9 (6 days ago), 2024-04-17 13:08:03 -0700
• Engine revision c4cd48e186
• Dart version 3.3.4
• DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version
34.0.0)
• Android SDK at /Users/erlend/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/erlend/Library/Android/sdk
• ANDROID_SDK_ROOT = /Users/erlend/Library/Android/sdk
• Java binary at: /Users/erlend/Applications/Android
Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
17.0.9+0-17.0.9b1087.7-11185874)
• All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15E204a
• CocoaPods version 1.15.2

[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
• Android Studio at /Users/erlend/Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.88.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.87.20240402

[✓] Connected device (3 available)
• Erlend sin iPhone (mobile) • 00008130-001E61A92403401C • ios • iOS 17.4.1 21E236
• macOS (desktop) • macos • darwin-arm64 • macOS 14.4.1 23E224 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 124.0.6367.62

[✓] Network resources
• All expected network resources are available.

• No issues found!
```

### Description

I noticed `firebase_options.dart` is not formatted correctly according to `dart format` (i got a built error on the server).

Diff after running dart format:

```
diff --git a/lib/firebase_options.dart b/lib/firebase_options.dart
index 22bbfef6..9c85f9e2 100644
--- a/lib/firebase_options.dart
+++ b/lib/firebase_options.dart
-
-}
\ No newline at end of file
+}
```

### Steps to reproduce

run `flutterfire configure`

### Expected behavior

I'd excpect it to be formatted according to `dart format`

### Screenshots

_No response_

### Additional context and comments

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.