inveniosoftware / inveniosoftware/react-searchkit
Analyse 'SearchBarUncontrolled' component.
Open
- Dominant language
- JavaScript
- Stars
- 83
- Forks
- 48
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 4
Description
This issue is created to analyse whether `SearchBar` component can be fully uncontrolled. Right now, its state variable `currentValue` is initialised based on the prop `queryString` which is controlled by the component's parent (``).
`queryString` is a prop currently connected by Redux to the store's state `state.query.queryString`
The current implementation is updating the component's internal state rather than the redux one.
https://github.com/inveniosoftware/react-searchkit/blob/9274d994803f572c36f29a69d32e3548d08db379/src/lib/components/SearchBar/index.js#L17-L20.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.