inveniosoftware / inveniosoftware/react-invenio-forms
Space needed between multiple name identifiers
- Dominant language
- JavaScript
- Stars
- 2
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Package version (if known): HEAD (seen on invenio-app-rdm@13.0.2)
## Describe the bug
When a name has multiple identifiers, they are sometimes combined with no space in between. This is visually unpleasing but also breaks screenreaders since they're reading not the identifier but the identifier with the next identifiers scheme postfixed.
## Steps to Reproduce
1. Create a name with multiple identifiers _not_ in the list of `makeIdEntry` cases (orcid, gnd, ror, isni, grid), example:
```yaml
- affiliations:
- id: 01mmcf932
family_name: Phetteplace
given_name: Eric
id: https://portal.cca.edu/people/ephetteplace/
identifiers:
- identifier: https://portal.cca.edu/people/ephetteplace/
scheme: url
- identifier: ephetteplace@cca.edu
scheme: email
```
2. Go to the deposit form
4. Add a Creator or Contributor
5. Search for a string that will bring up the name, e.g. "Phetteplace"
6. The two id strings are stuck together: `url: https://portal.cca.edu/people/ephetteplace/email: ephetteplace@cca.edu`
## Expected behavior
There should be a space in between each identifier and the scheme of the following one: `url: https://portal.cca.edu/people/ephetteplace/ email: ephetteplace@cca.edu`
## Screenshots (if applicable)
## Additional context
This occurs in src/lib/elements/contrib/invenioRDM/records/AffiliationsSuggestions.js and could be fixed in either the `makeIdEntry` or `AffiliationsSuggestions` functions. I will submit a small PR.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.