inveniosoftware / inveniosoftware/react-invenio-app-ils

SessionManager refactor

Open
#52 0 comments 0 reactions 0 assignees View on GitHub
nice-to-have refactor
Dominant language
JavaScript
Stars
6
Forks
24
Avg merge
2d 46m
Merged PRs (30d)
3

Description

Review all the code that uses current_user information outside a react component and therefore needs to take information from SessionManager. If we get rid of these places then the implementation could be simplified by removing the SessionManager class

Basically review if we can access the user information only via redux state - if this is possible, then we could remove the `SessionManager` class, to avoid "duplication"

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the SessionManager class and every use of current_user outside React components, then compare those accesses with the Redux state. The work is done when user information can be accessed through Redux alone and the SessionManager class can be removed without losing required behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, redux
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.