inveniosoftware / inveniosoftware/react-invenio-app-ils

modals: avoid mounting the component when not visible

Open
#31 1 comment 0 reactions 0 assignees View on GitHub
bug refactor
Dominant language
JavaScript
Stars
6
Forks
24
Avg merge
2d 46m
Merged PRs (30d)
3

Description

Currently the modal with semantic-ui is in this form (a button inside the modal):
```
{
this.setState({ modalOpen: true });
}

handleClose() => {
this.setState({ modalOpen: false });
}

render() => {
Show Modal
{this.state.modalOpen && ()
}
```

There might be another better solution.

**TODO**
- fix the way we use modals
- find and fix all modals in the app

Ping @zzacharo @kprzerwa @topless if you have better ideas.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating RelationModal and the other modal usages in the app; reproduce the page with two modals and observe the render logs described in the issue. Done means hidden modals are not mounted or re-rendered, while opening and closing still works for every modal usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.