inveniosoftware / inveniosoftware/invenio-theme
What happens if `self.icon_key` is not a key in `current_theme_icons`?
Open
- Dominant language
- HTML
- Stars
- 9
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
What happens if `self.icon_key` is not a key in `current_theme_icons`?
Should this yield an error to warn the developer or should it render the menu entry without its icon?
_Originally posted by @alejandromumo in https://github.com/inveniosoftware/invenio-administration/pull/23#discussion_r957359075_
Contributor guide
Research direction
Start by tracing where self.icon_key and current_theme_icons are defined and how the menu entry is rendered. Compare the behavior for a missing icon key and determine, with maintainers, whether the intended outcome is an error or a menu entry without an icon. Done requires a documented decision and corresponding coverage.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100