inveniosoftware / inveniosoftware/dictdiffer

Float comparator does not handle inf correctly

Open
#146 0 comments 0 reactions 0 assignees View on GitHub
Lane: help wanted Need: tests Size: beginner-friendly Type: bug
Dominant language
Python
Stars
849
Forks
99
PR merge metrics
No merged PRs in 30d

Description

Noticed this a while ago, sorry for delay.
ex:
```
a1 = {'a': [1.0, 2.0, 3.0, 4.0]}
a2 = {'a': [1.0, 2.0, 3.0, float('inf')]}
```
dictdiffer.diff does not return any differences for these two dictionaries.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.