invenia / invenia/FeatureTransforms.jl

Set default value for `append_dim` as `dims` inside `apply_append`

Open
#70 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Julia
Stars
37
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Looking at some tests repeating `dims=x, append_dim=x` made me think, would it make sense to set the default value for `append_dim` as `dims` inside the function? Maybe that only works when `dims` is single, as is currently the case.

_Originally posted by @bencottier in https://github.com/invenia/FeatureTransforms.jl/pull/69#discussion_r604254552_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.