invenia / invenia/FTPClient.jl

`download` doesn't like spaces in the filename

Open
#124 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
22
Forks
4
PR merge metrics
No merged PRs in 30d

Description

As from the title, the download function doesn't like spaces in the filename :

julia> using FTPClient

julia> ftp_init();

julia> ftp = FTP(hostname = "palantir.boku.ac.at", username = "anonymous", password = "");

julia> download(ftp, "/Public/MODIS_EURO/EU_NPP_2000.tif", "test.tif")
ftp://anonymous@palantir.boku.ac.at//Public/MODIS_EURO/EU_NPP_2000.tif
IOStream(<file test.tif>)

julia> download(ftp, "/Public/MODIS_EURO/Neumann et al._2016_Creating a Regional MODIS Satellite-Driven Net Primary Production Dataset for European Forests.pdf", "test.pdf")
ftp://anonymous@palantir.boku.ac.at//Public/MODIS_EURO/Neumann et al._2016_Creating a Regional MODIS Satellite-Driven Net Primary Production Dataset for European Forests.pdf
ERROR: Failed to download /Public/MODIS_EURO/Neumann et al._2016_Creating a Regional MODIS Satellite-Driven Net Primary Production Dataset for European Forests.pdf. :: LibCURL error #3
Stacktrace:
 [1] macro expansion
   @ ~/.julia/dev/FTPClient/src/FTPC.jl:62 [inlined]
 [2] ftp_perform(ctxt::ConnContext{Bool})
   @ FTPClient ~/.julia/dev/FTPClient/src/conn_context.jl:301
 [3] ftp_get(ctxt::ConnContext{Bool}, file_name::String, save_path::String; mode::FTP_MODE)
   @ FTPClient ~/.julia/dev/FTPClient/src/conn_context.jl:155
 [4] download(ftp::FTP, file_name::String, save_path::String; mode::FTP_MODE)
   @ FTPClient ~/.julia/dev/FTPClient/src/FTPObject.jl:118
 [5] download(ftp::FTP, file_name::String, save_path::String)
   @ FTPClient ~/.julia/dev/FTPClient/src/FTPObject.jl:110
 [6] top-level scope
   @ REPL[13]:1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the download path shown in src/FTPObject.jl:118 and the ftp_get implementation in src/conn_context.jl:155, then inspect the LibCURL call reported at src/FTPC.jl:62. Reproduce the issue using the filename with spaces and compare it with the working .tif download. Done means download succeeds for the PDF path and the existing error is no longer raised.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.