intuit / intuit/simple_deploy

Review error handling

Open
#189 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Ruby
Stars
63
Forks
20
PR merge metrics
No merged PRs in 30d

Description

@bradly receieved a transient error than did not appear to be handled correctly. We should verify that our error handling logic is sound.

2013-05-21 19:22:21 -0700 INFO : Updating Cloud Formation stack lc-pod-2-e2e-1-worker-2.
/Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/aws/cloud_formation/error.rb:14:in `process': undefined method`response' for #Excon::Errors::SocketError:0x007fef7fb74c30 (NoMethodError)
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/aws/cloud_formation.rb:32:in `rescue in update'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/aws/cloud_formation.rb:26:in`update'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/stack/stack_updater.rb:29:in `update'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/stack/stack_updater.rb:17:in`update_stack_if_parameters_changed'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/stack.rb:53:in `update'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/cli/deploy.rb:74:in`block (2 levels) in deploy'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/cli/shared.rb:43:in `rescue_exceptions_and_exit'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/cli/deploy.rb:73:in`block in deploy'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/cli/deploy.rb:62:in `each'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/cli/deploy.rb:62:in`deploy'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/lib/simple_deploy/cli.rb:39:in `start'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/gems/simple_deploy-0.7.3/bin/simple_deploy:6:in`'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/bin/simple_deploy:19:in `load'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/bin/simple_deploy:19:in`'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/bin/ruby_noexec_wrapper:14:in `eval'
from /Users/bfeeley/.rvm/gems/ruby-1.9.3-p385@lc/bin/ruby_noexec_wrapper:14:in`'

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.