intuit / intuit/simple_deploy

Catch errors in sending notifications, log warning and continue.

Open
#156 0 comments 0 reactions 1 assignee Claimed by @ccloes-intuit View on GitHub
enhancement
Dominant language
Ruby
Stars
63
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Currently notification exceptions will be raised and cause the deployment to fail. These should be caught and log as a warning, then continue to keep from disrupting deployments.

2013-02-14 23:15:02 -0800 DEBUG : Sending notification to Campfire room 472802.
/Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:762:in `initialize': Operation timed out - connect(2) (Errno::ETIMEDOUT)
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:762:in`open'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:762:in `block in connect'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/timeout.rb:54:in`timeout'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/timeout.rb:99:in `timeout'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:762:in`connect'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:755:in `do_start'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:744:in`start'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:1284:in `request'
from /Users/vsomayaji/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/net/http.rb:1026:in`get'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/adapter/net_http.rb:59:in `call'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/response.rb:8:in`call'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/response.rb:8:in `call'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/response.rb:8:in`call'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/response.rb:8:in `call'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/request/json.rb:32:in`call'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/connection.rb:210:in `run_request'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/faraday-0.7.6/lib/faraday/connection.rb:93:in`get'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/tinder-1.8.0/lib/tinder/connection.rb:76:in `get'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/tinder-1.8.0/lib/tinder/campfire.rb:34:in`rooms'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/tinder-1.8.0/lib/tinder/campfire.rb:41:in `find_room_by_id'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/notifier/campfire.rb:30:in`block in send'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/notifier/campfire.rb:28:in `each'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/notifier/campfire.rb:28:in`send'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/notifier.rb:40:in `block in send'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/notifier.rb:34:in`each'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/notifier.rb:34:in `send'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/notifier.rb:15:in`send_deployment_start_message'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/cli/deploy.rb:81:in `block in deploy'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/cli/deploy.rb:59:in`each'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/cli/deploy.rb:59:in `deploy'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/lib/simple_deploy/cli.rb:39:in`start'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/gems/simple_deploy-0.6.7/bin/simple_deploy:6:in `'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/bin/simple_deploy:19:in`load'
from /Users/vsomayaji/.rvm/gems/ruby-1.9.3-p194@simple_deploy/bin/simple_deploy:19:in `'

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.