intuit / intuit/simple_deploy

Deploy command should not build APP_URL if there is no app

Open
#126 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Ruby
Stars
63
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Discovered this while testing LC Solr deploys. The Solr stacks don't have an app as everything they need is in cookbooks and chef_repo.

Looks like simple_deploy is building an invalid URL rather than my expectation of it not building one at all.
APP_URL=s3://-us-west-1//.tar.gz

I vote for skipping APP_URL if app is nil. We'll need to test how simple_deploy/stackster handles a nil APP_URL.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.