intuit / intuit/devtools-ds

Improve CSS Variables and Theming

Open
#13 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
272
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Currently the CSS variables are un-scoped, and don't really follow a strict naming convention. We could really improve this part of the project with a few enhancements:

- Add a scope. Maybe `devtools-ds`? This would stop really generic variable names like `textColor` from colliding with variables in the page. We could look at scopes for other packages for ideas.
- Add variables to the docs. Once we have a scope we can make it available as a "theming" API for components. This is a _bit_ of a can of worms since variable name changes are now breaking API changes.
- Improve variable names. Just make sure they are consistent and make sense, since they'll become an API.

Open to thoughts and suggestions.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.