intuit / intuit/design-systems-cli

Tests do not fail if coverage does not meet thresholds

Open
#670 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
419
Forks
89
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

When running `yarn test`, if your tests do not meet jest coverage thresholds, your tests will still pass.

**To Reproduce**

Add a coverage threshold that is not met, and verify that test will still pass, even though an error is showing.

**Expected behavior**

If coverage thresholds are added, and they aren't met, the tests should fail. Preferably it would specify that it failed due to coverage.

**Screenshots**

![image (3)](https://user-images.githubusercontent.com/9298984/139956262-77c7a6b1-399c-4ad6-b798-68446ce2e22d.png)

**Desktop (please complete the following information):**

- OS: MacOS Big Sur (11.6)
- Browser: N/A
- Version `"@design-systems/cli": "4.13.1",`

**Additional context**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.