intuit / intuit/auto

auto version skipRelease behaviour

Open
#2,372 6 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
2.5k
Forks
221
PR merge metrics
No merged PRs in 30d

Description

I'm trying to release feature branch;

I have several pr-s in these branch, some of them are minors, some patches and some ci commits that should be skipped;
I merged itб but auto decided to skip my release

Please help me understand this behaviour

My labels:

```
prLabels [
[ 'plasma-infra', 'skip-release' ],
[ 'skip-release' ],
[ 'skip-release' ],
[ 'skip-release' ],
[ 'skip-release' ],
[ 'minor' ],
[ 'minor' ],
[ 'plasma-infra', 'Hotfix', 'skip-release' ],
[ 'patch' ],
[ 'plasma-infra', 'skip-release' ],
[ 'skip-release' ],
[ 'skip-release' ],
[ 'plasma-infra', 'skip-release' ],
[ 'skip-release' ],
[ 'skip-release' ],
[ 'skip-release' ],
[ 'minor' ],
[ 'minor' ],
[ 'skip-release' ]
]

```

yes the last pr to feature branch is CI related, but I don't understand why we should skip release if only last label is 'skip-release' ?

the code I am asking about:

https://github.com/intuit/auto/blob/main/packages/core/src/semver.ts#L221-L223

```js
const skipRelease = onlyPublishWithReleaseLabel
? !lastMergedCommitLabels.some((label) => releaseLabels.includes(label))
: lastMergedCommitLabels.some((label) => skipReleaseLabels.includes(label));
```

I don't understand why lastMergedCommit is more important then all other commits

```txt
Environment Information:

"auto" version: v10.36.6
"git" version: v2.32.1 (Apple Git-133)
"node" version: v14.21.2

Project Information:

✔ Repository: salute-developers/plasma
✔ Author Name: Vasiliy Loginevskiy
✔ Author Email: yeti.or@gmail.com
✖ Current Version: v
✔ Latest Release: @salutejs/plasma-website@0.182.0

✖ Labels configured on GitHub project (Try running "auto create-labels")

GitHub Token Information:

✔ Token: [Token starting with 3b3d]
✖ Repo Permission: read
✔ User: Eva
✔ API:
✔ Enabled Scopes: gist, notifications, repo, user, workflow, write:discussion, write:packages
✔ Rate Limit: 4447/5000
```

**Additional context**

I use conventional-commits plugin to calc version bump

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.