intuit / intuit/auto

[Question] Why pr-check doesn't have an option to throw an error?

Open
#2,367 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.5k
Forks
221
PR merge metrics
No merged PRs in 30d

Description

The question I have is about the way `pr-check` works in GitHub Actions. When I run it in actions, the script runs and exits with `0`, so in GitHub Actions I see that everything is okay, but in my PR I see an error. I didn't find any option, to exit with code `1` if there are some issues.

The reason why I need it is that my workflow contains two steps (Check -> Build) and when Check is failed (lint, or no label in PR) I want to throw an error and ignore build scripts.

**Actual result:**
* On the Actions page it says that the job is completed with no errors
* On the PR page it says "No semver label!"

**Expected result:**
* On the Actions page it shows an error and the next job (build) is not starting
* On the PR page it says "No semver label"

Let me know if there is another approach I could use for that or if you need some repo to see the problem 😊

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.