intuit / intuit/QuickBooks-V3-Java-SDK

Url's port ignored when Apache HTTP Client is used

Open
#182 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
88
Forks
158
PR merge metrics
No merged PRs in 30d

Description

Default http transport is Apache HTTP Client ([link](https://github.com/intuit/QuickBooks-V3-Java-SDK/blob/ff20a52b67c2d0fbbb14cf5c4802e13a116c6d35/ipp-v3-java-devkit/src/main/java/com/intuit/ipp/util/Config.java#L176-L179)). But it doesn't support url port (ie. I can't use http://locahost:8080/ as `BASE_URL_QBO` in tests. Requests will be made to `localhost:80`).

I think root cause is that `-1` is used as `port` in HttpTarget ([source](https://github.com/intuit/QuickBooks-V3-Java-SDK/blob/ff20a52b67c2d0fbbb14cf5c4802e13a116c6d35/ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/HTTPClientConnectionInterceptor.java#L158))
Is it possible to replace hardcoded value with `url.getPort()` (if port ommitted - it returns `-1` anyway)? Happy to open PR.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.