intuit / intuit/QuickBooks-V3-DotNET-SDK

Serilog dependencies broken again

Open
#282 1 comment 5 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
121
Forks
145
Avg merge
17h 1m
Merged PRs (30d)
1

Description

DLL hell again.

[MissingMethodException: Method not found: 'Serilog.LoggerConfiguration Serilog.FileLoggerConfigurationExtensions.File(Serilog.Configuration.LoggerSinkConfiguration, System.String, Serilog.Events.LogEventLevel, System.String, System.IFormatProvider, System.Nullable`1, Serilog.Core.LoggingLevelSwitch, Boolean, Boolean, System.Nullable`1, Serilog.RollingInterval, Boolean, System.Nullable`1, System.Text.Encoding, Serilog.Sinks.File.FileLifecycleHooks)'.]
Intuit.Ipp.OAuth2PlatformClient.Diagnostics.OAuthAdvancedLogging..ctor(Boolean enableSerilogRequestResponseLoggingForDebug, Boolean enableSerilogRequestResponseLoggingForTrace, Boolean enableSerilogRequestResponseLoggingForConsole, Boolean enableSerilogRequestResponseLoggingForFile, String serviceRequestLoggingLocationForFile) in C:\Users\nshrivastava\Documents\GitHub\QuickBooks-V3-DotNET-SDK\IPPDotNetDevKitCSV3\Code\Intuit.Ipp.OAuth2PlatformClient.Diagnostics\OAuthAdvancedLogging.cs:238
Intuit.Ipp.OAuth2PlatformClient.OAuth2Client.GetAuthorizationURL(List`1 scopes)

Please remove ALL Serilog dependencies so I can add a custom ILogger with whatever logging framework (including latest Serilog) I want. Or can we at least branch a version which doesn't use them.

Using:
IppDotNetSdkForQuickBooksAPIV3 - 14.6.3.2

Installed the latest versions of Serilog
Assembly - Recommended - Installed
Serilog >=2.10.0 - 2.12.0
Serilog.Enrichers.Environment >= 2.1.3 - 2.2.0
Serilog.Enrichers.Thread >= 3.1.0 - 3.1.0
Serilog.Extensions.Logging >= 3.0.1 - 3.1.0
Serilog.Settings.Configuration >=3.1.0 - 3.4.0
Serilog.Sinks.Console >= 3.1.1 - 4.1.0
Serilog.Sinks.Debug >= 2.0.0 - 2.0.0
Serilog.Sinks.File >= 4.1.0 - 5.0.0
Serilog.Sinks.Trace >= 2.1.0 - 3.0.0
SerilogTraceListener >= 3.2.0 - 3.2.0

Will have to downgrade everything. I thought I may have been able to downgrade Serilog.Sinks.File back to 4.1.0 but this is not enough

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.