intility / intility/json-api-toolkit

Enable TreatWarningsAsErrors and analyzers repo-wide

Open
#140 0 comments 0 reactions 1 assignee View on GitHub

@erlendellefsen is already working on this.

Since Aug 20, 2026.

.NET enhancement
Dominant language
C#
Stars
7
Forks
0
Avg merge
1d 4h
Merged PRs (30d)
23

Description

The build does not enforce warnings or analyzers. For a published library this is the wrong default. Land this last so the cleanup PRs are already in.

Acceptance criteria

  • Directory.Build.props sets TreatWarningsAsErrors=true, EnableNETAnalyzers=true, EnforceCodeStyleInBuild=true, AnalysisMode=Recommended (or stricter)
  • All resulting warnings either fixed or explicitly suppressed in .editorconfig with a justification
  • CI build is green
  • Test project may opt out if generated-code noise is unmanageable; document any opt-out

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.