intility / intility/json-api-toolkit
Make JsonApiFilterParser.s_separator private and immutable
Open
@erlendellefsen is already working on this.
Since Aug 20, 2026.
.NET
bug
- Dominant language
- C#
- Stars
- 7
- Forks
- 0
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 23
Description
JsonApiToolkit/Parsing/JsonApiFilterParser.cs:15 exposes public static readonly string[] s_separator. The array contents are mutable, so any caller can change them and break filter parsing for the whole process. The s_ prefix on a public field also breaks the editorconfig naming rule.
Acceptance criteria
- Field is private (or replaced with a private const string)
- No way to mutate it from outside the class
- All call sites updated, tests pass
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.