intersystems / intersystems/ipm

Validate resource and document names are the same

Open
#1,104 0 comments 0 reactions 0 assignees View on GitHub
documentation prio: low
Dominant language
ObjectScript
Stars
41
Forks
29
Avg merge
23h 54m
Merged PRs (30d)
4

Description

When investigating an issue related to an HL7 file being exported with none of the data inside it, the reasoning ended up being that the file name and document name (in the tag in the file) were different. Importing was under the document name where exporting uses the file name, leading to an empty exported file (since there were no imported values associated with it). The solution was to add a guideline that the document name and file names should be the same.

To enforce this guideline, we want to add a validation check during import of the resource (`OnLoad()`) to confirm these names are equivalent.

We should also test and confirm the functionality for LOC and interop resources to see what other file types this functionality affects.

Example problem case: File name is `MyFile.HL7` that includes a document tag of ``. Document loaded in as `My-File.HL7` but export tries to use `MyFile.HL7`

Contributor guide

Open the contributing guide

Research direction

Start at the resource import path and its OnLoad() method, then trace how the document name and source file name are obtained. Check the behavior for HL7, LOC, and interop resources; done means mismatched names are rejected during import and matching names continue to work.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.