intersystems / intersystems/iknow

Engine C/C++ external APIs should convert to UTF-8

Open
#21 1 comment 0 reactions 1 assignee Claimed by @JosDenysGitHub View on GitHub
Dominant language
C++
Stars
54
Forks
22
PR merge metrics
No merged PRs in 30d

Description

https://github.com/intersystems/iknow/blob/60b1c74224c29ae6a32bb9acac8677b1e7f58ef6/modules/iknowpy/engine.pxd#L30

This line suggests the engine API is exposing our internal UTF-16 string representation. Though cognizant of the performance hit, I think we need an API where all string content is ordinary char*'s of UTF-8 (maybe not the only one, but certainly the one that code like @adang1345's would use)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.