intersystems / intersystems/git-source-control

Incorrect warning shown in settings when Code Tidy is installed as a secondary extension

Open
#924 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
ObjectScript
Stars
22
Forks
14
Avg merge
1d 9h
Merged PRs (30d)
5

Description

When using the Code Tidy extension together with the Git Source Control for InterSystems extension, the settings page displays a warning indicating that the current extension configuration is not recommended. However, Code Tidy intentionally registers itself as a secondary extension, which allows Git Source Control to function correctly within the namespace.

Despite the configuration being valid, the warning continues to appear. This misleads users into changing the setting, which then breaks Code Tidy’s intended behaviour.

**Expected Behaviour**

If Code Tidy is installed and has correctly registered itself as a secondary extension, the settings page should not display the warning.

**Actual Behaviour**

The warning is always shown, even when the configuration is valid due to Code Tidy being installed, and Git Source Control works as the Source Control extension.

**Steps to Reproduce**

1. Install and Configure Git Source Control for InterSystems.
3. Install and Configure Code Tidy.
4. Setup the Code Tidy extension by executing `do ##class(pkg.isc.codetidy.Utils).SetupExtension()`
5. Open the extension settings for Git Source Control.
6. Observe that the warning is displayed even though the configuration is correct.
**Impact**

Users may mistakenly change a valid configuration, resulting in Code Tidy no longer functioning as designed.

**Proposed Fix**

Add logic to detect if Git Source Control is installed and registered as a secondary extension alongside Code Tidy, and suppress the warning accordingly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.