intersystems / intersystems/git-source-control
Clean up testing artifact created by UnitTest.SourceControl.Git.NameToInternalNameTest
- Dominant language
- ObjectScript
- Stars
- 22
- Forks
- 14
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 5
Description
The unit test class UnitTest.SourceControl.Git.NameToInternalNameTest uses OnBeforeAllTests to copy the entire project tree into a temporary folder:
https://github.com/intersystems/git-source-control/blob/8aa09fdcc0b4fa8d384d8b8cb16dd6d2e8ae26eb/test/UnitTest/SourceControl/Git/NameToInternalNameTest.cls#L119-L123
But the cleanup (done for unknown reasons in %OnClose rather than OnAfterAllTests) doesn't remove that folder afterwards:
https://github.com/intersystems/git-source-control/blob/8aa09fdcc0b4fa8d384d8b8cb16dd6d2e8ae26eb/test/UnitTest/SourceControl/Git/NameToInternalNameTest.cls#L139-L148
A search for `##class(%Library.File).TempFilename()` shows other unit test classes that are similarly lazy in their housekeeping.
Contributor guide
Assessment
This issue has not been assessed yet.