intersystems / intersystems/git-source-control

Fix behavior on nginx

Open
#704 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
ObjectScript
Stars
22
Forks
14
Avg merge
1d 9h
Merged PRs (30d)
5

Description

From separate internal investigation (internal ref: DP-437290):

The Git Source Control module uses a CGI variable of REQUEST_URI during URL parsing / construction.

Relevant code in webuidriver.csp:
`Set url = $Piece($Get(%request.CgiEnvs("REQUEST_URI"),$Get(%request.CgiEnvs("HTTP_URL"))),"?")`

However, traffic from the Nginx web gateway does not come with this variable and causes "Set url" to an empty string and the malformed URL mentioned in the customer's description. (i.e. this variable is good with Apache, not Nginx).

For a workaround for Nginx users, adding this line of code right after the above one fixes the issue.
`Set:(url="") url = %request.URL _ %request.CgiEnvs("PATH_INFO")`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.