internetarchive / internetarchive/warcprox

`fcntl` module does not exist on Windows

Open
#164 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
467
Forks
66
PR merge metrics
No merged PRs in 30d

Description

`warcprox/writer.py` imports `fcntl` to acquire an exclusive lock on files opened for writing, but this fails on Windows because the `fcntl` module is only available on Unix-like systems. It should either gracefully degrade to not use file locking if the module is not available, or use a portable library like [`portalocker`](https://pypi.org/project/portalocker/).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in warcprox/writer.py at the fcntl import and the file-locking path used for files opened for writing. Check how the module behaves when fcntl is unavailable and compare graceful degradation with using portalocker. Done means the module can run on Windows without failing at the import or locking step, with the chosen behavior verified there.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.