internetarchive / internetarchive/openlibrary

Workflow to catch python deprecation warnings sooner

Open
#9,749 0 comments 0 reactions 0 assignees View on GitHub
Lead: @jimchamp Needs: Community Discussion Needs: Staff Decision Priority: 3 Type: Feature Request Type: Proposal
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Problem

In the past, python library deprecations have results in breaking changes when we upgraded python packages. For instance our PIL twitter list preview image system broke because we were using deprecated methods that were removed when we upgraded PIL. To detect usage of deprecated methods sooner, oroposing a workflow with 2 pieces:
1. Monday at 9am workflow
2. PR check if author is renovatebot or dependabot

If [1] then create an issue based on the python package name (e.g. `[PACAKGE] Deprecation Warning`) and if [2] leave a comment on the PR with deprecation warning message.

### Proposal & Constraints

### What is the proposed solution / implementation?

### Is there a precedent of this approach succeeding elsewhere?

### Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

### Leads

### Related files

### Stakeholders


### Instructions for Contributors

- Please [run these commands](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.