internetarchive / internetarchive/openlibrary

Searching for "author:brock" should also search alternate author names

Open
#9,596 2 comments 0 reactions 0 assignees View on GitHub
Lead: @cdrini Needs: Breakdown Priority: 3 Theme: Search Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Problem

#### Evidence / Screenshot

#### Relevant URL(s)
e.g. https://openlibrary.org/search?q=title%3A%22Kink%22+author%3ABrock&mode=everything&fields=key%2Ctitle%2Cauthor_name%2Ccover_i%2Cfirst_publish_year%2Cedition_count%2Cebook_access%2Clending_identifier_s%2Cpublic_scan_b%2Cpublic_scan_a

### Reproducing the bug

1. Go to https://openlibrary.org/search?q=title%3A%22Kink%22+author%3ABrock&mode=everything&fields=key%2Ctitle%2Cauthor_name%2Ccover_i%2Cfirst_publish_year%2Cedition_count%2Cebook_access%2Clending_identifier_s%2Cpublic_scan_b%2Cpublic_scan_a

* Expected behavior: https://openlibrary.org/works/OL10142666W?edition=key%3A/books/OL21005761M should be a result
* Actual behavior: No results

### Context

- Browser (Chrome, Safari, Firefox, etc):
- OS (Windows, Mac, etc):
- Logged in (Y/N): Y
- Environment (prod, dev, local): prod

### Notes from this Issue's Lead

#### Proposal & constraints

#### Related files

https://github.com/internetarchive/openlibrary/blob/46dcefd643bb4821b70d847ecf0fc1a06eb16f8d/openlibrary/plugins/worksearch/schemes/works.py#L108-L110

#### Stakeholders


#### Instructions for Contributors

- Please [run these commands](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.