internetarchive / internetarchive/openlibrary

Author name resolution unit tests should be case sensitive

Open
#9,391 3 comments 0 reactions 1 assignee Claimed by @Suhani370 View on GitHub
Lead: @cdrini Module: Authors Priority: 3 Theme: Testing Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Problem

Related: #9390, #9003, internetarchive/infogami#221

#### Evidence / Screenshot
https://github.com/internetarchive/infogami/pull/221 will cause Infogami's `~` behavior go back to doing a `LIKE` operation, and this will cause Infogami's `~` behavior to go out of sync with the `mock_infobase` behavior added in #9003, which made `~` case insensitive. `mock_infobase` and the unit tests will need to be updated to be case _sensitive_.

Once/if #9390 is implemented, these test will need to be made case insensitive again, but until that happens, they should be case sensitive.

See #9003 for the exact files to update to make the name resolution tests case sensitive once more.

#### Relevant URL(s)

### Reproducing the bug

_No response_

### Context

_No response_

### Notes from this Issue's Lead

#### Proposal & constraints

#### Related files

#### Stakeholders

**Note:** Before [making a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) _or_ updating an existing one, please [ensure your branch is up to date](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.