internetarchive / internetarchive/openlibrary

Changes to Author names are not updated in Solr's index of Works

Open
#891 20 comments 0 reactions 0 assignees View on GitHub
Lead: @cdrini Module: Solr Priority: 3 Type: Bug Type: Subtask of Epic
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

from @LeadSongDog commenting on #349

> 1. For instance, this morning I did some changes at OL35246A, including disinverting his name. As you can see, it still shows the inverted author name for each work listed at https://openlibrary.org/authors/OL35246A/William_Henry_Brown
>
> 2. Further, the works shown on the author page do not reflect changes that do show when you click through, e.g. the 1963 "Organic chemisty" [sic] which was by a different author entirely, as is now seen at https://openlibrary.org/works/OL16120915W/Organic_chemistry
>
> 3. The edition counts shown on the Author page do not agree with (they lag) the edition counts shown on the listed Work pages. The "What work is this an edition of" dropdown has the same lagging edition count.
>
> 4. Searching either "Title" or "All" for "Organic chemisty" still shows the author as William Henry Brown vice the now-corrected Frederick G. Bordwell which shows once you click on the found work.

Currently the code that updates author information in Solr does not trigger any reindexes of Works, which accounts for 1,2, and 4. 3 seems like an inverse of this, Author data needs to be updated when Work/Editions change. [TODO: create an issue for Author edition counts]

**Proposal:**

If any author field that is indexed against Works is changed on the Author record,
all Works of that Author need to be re-indexed (/updated)

The following Author fields are stored against Works in Solr:

```



```
taken from https://github.com/internetarchive/openlibrary/blob/bdb69c2a3be687f7b4f60fd6c41b03d475a2e331/conf/solr/conf/schema.xml#L480

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.