internetarchive / internetarchive/openlibrary

"Only ebooks" filter on author pages hides "Preview Only" books

Open
#8,888 14 comments 0 reactions 0 assignees View on GitHub
Affects: Experience Lead: @cdrini Module: Borrowing / Lending Needs: Community Discussion Needs: Designs Priority: 3 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Problem

To reproduce the bug, go to this author page and see this book listed:
https://openlibrary.org/authors/OL6708339A/John_D._MacDonald?mode=everything&sort=rating
![Screenshot_20240308-232533_Chrome](https://github.com/internetarchive/openlibrary/assets/19307323/b43b602c-ffc7-4869-afc1-9f6964bb1c05)

When you use the "only ebooks" filter on this author age, this "Preview Only" book isn't shown:
https://openlibrary.org/authors/OL6708339A/John_D._MacDonald?mode=ebooks&sort=rating

### Reproducing the bug

* Expected behavior: "Preview Only" books are not hidden when the "only ebooks" filter is used on author pages.
* Actual behavior: "Preview Only" books are hidden when the "only ebooks" filter is used on author pages.

Thank you for looking into this.

### Context

- Browser (Chrome, Safari, Firefox, etc): Chrome
- OS (Windows, Mac, etc): Android
- Logged in (Y/N): Y
- Environment (prod, dev, local): prod

### ⚠️ Experienced contributors only

### Proposal & constraints

### Related files

### Stakeholders

Contributor guide

Open the contributing guide

Research direction

Start by comparing the linked author page in `mode=everything` with the same page using `mode=ebooks`, and trace the author-page filter behavior that excludes the Preview Only book. Done means Preview Only books remain visible when the only ebooks filter is selected, while the existing filter behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.