internetarchive / internetarchive/openlibrary

Add validation to checks to book editing fields

Open
#7,899 3 comments 0 reactions 0 assignees View on GitHub
Lead: @cdrini Priority: 4 Type: Feature Request
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Describe the problem that you'd like solved

In the book editing screen, it is possible to place invalid values, below I will place the fields tested with real values, in the title and subtitle fields it is possible to place no value, in the date field it is possible to place a string instead of a date, in the In the book weight field, it is possible to enter unrealistic values such as: 100,000kg. In the fields of the dimensions of the book, it is also possible to put values that are absurdly large and unrealistic.

### Proposal & Constraints

To solve the problems mentioned is very simple, just putting some checks in the fields will solve the problem. In all fields it is necessary to place character limits and also to type the information passed, in the date field only numbers must be placed, and in the weight and size fields valid sizes must be placed, limiting the values.

### Stakeholders

@gojomo
@EdwardBetts
@anandology
@nileshtrivedi

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.