internetarchive / internetarchive/openlibrary

Spurious edits adding blank lines to /config/edition

Open
#7,840 0 comments 0 reactions 0 assignees View on GitHub
Affects: Data Affects: Librarians Lead: @cdrini Priority: 3 Theme: Editing Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

History of any significant changes to file is masked by the flood of insignificant ones

### Evidence / Screenshot (if possible)

### Relevant url?

https://openlibrary.org/config/edition?_compare=Compare&b=893&a=892&m=diff

### Steps to Reproduce

1. Go to https://openlibrary.org/config/edition
2. Click on History
3. Select any of the edits made by admin
4. Select the diff before and after that edit

* Actual: diff shows blank lines and only blank lines added
* Expected: no blank edits saved

### Details

- **Logged in (Y/N)?** y
- **Browser type/version?** any
- **Operating system?** any
- **Environment (prod/dev/local)?** prod

### Proposal & Constraints

### Related files

### Stakeholders

Related: #6353

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.