internetarchive / internetarchive/openlibrary

Merge queue does not remove closed requests

Open
#7,207 5 comments 0 reactions 0 assignees View on GitHub
Lead: @jimchamp Module: Merge Queue Needs: Investigation Priority: 3 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

Under certain circumstances, works are not cleared out of the merge queue despite having been merged. This seems usually to happen if a librarian set a primary work in the URL and that is later ignored by the librarian doing the merge.

### Evidence / Screenshot (if possible)
![Screenshot_20221201_105819](https://user-images.githubusercontent.com/36878944/205023741-24b6ca7d-b7f4-4c31-90e9-0c15adc61773.png)

![Screenshot 2022-12-01 at 11-01-40 merges Open Library](https://user-images.githubusercontent.com/36878944/205024191-d14fe9f0-f627-4683-a426-c7ec321a8503.png)

### Relevant url?

https://openlibrary.org/merges

### Steps to Reproduce

1. Go to Merge list
2. Click on "merge" to review a merge request
3. Remove a primary work set by a librarian from the URL
4. Either merge or reject the merge
5. The merge request remains in the list, even though it has been dealt with.

* Actual: Merge request remains in review limbo.
* Expected: Merge request is closed.

### Details

- **Logged in (Y/N)?**
- Y
- **Browser type/version?**
- Firefox 107 (64 bit)
- **Operating system?**
- Suse Tumbleweed
- **Environment (prod/dev/local)?** prod
- prod

### Proposal & Constraints

I have no idea how that could be solved. At the moment, I manually re-open the request and then close it.

### Related files

#6996
#6816

### Stakeholders

Librarians with merge capabilities
@seabelis @mheiman @mekarpeles

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.