internetarchive / internetarchive/openlibrary

Merge UI should not allow merge if records have changed in the mean time

Open
#6,675 4 comments 0 reactions 0 assignees View on GitHub
Affects: Librarians Lead: @jimchamp Priority: 3 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

When a super librarian clicks on the merge button the underlying code will re-fetch all the works/docs and if there are any edits (since) the UI will inform them to refresh

### Evidence / Screenshot (if possible)

### Relevant url?

### Steps to Reproduce

1. Go to ...
2. Do ...

* Actual:
* Expected:

### Details

- **Logged in (Y/N)?**
- **Browser type/version?**
- **Operating system?**
- **Environment (prod/dev/local)?** prod

### Proposal & Constraints

### Related files

### Stakeholders

Contributor guide

Open the contributing guide

Research direction

The issue names the merge button and the re-fetch of works and documents, but no files or tests. Start by locating the merge UI and its re-fetch path; done means edits made since the merge began prevent the merge and tell the super librarian to refresh.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.